This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Save SSE registers to generated core files, without breaking other architectures
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Michael Snyder <msnyder at redhat dot com>,Daniel Jacobowitz <drow at mvista dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 14 Apr 2002 18:22:13 -0400
- Subject: Re: [RFA] Save SSE registers to generated core files, without breaking other architectures
- References: <20020402145546.A7582@nevyn.them.org> <3CAA274A.C0170CF@redhat.com>
> Daniel Jacobowitz wrote:
>
>>
>> How does this patch look? The original problem was that we can not rely on
>> HAVE_PTRACE_FPXREGSET, because the presence of PTRACE_FPXREGSET doesn't
>> imply that GDB has a fill_fpxregset function available. I updated it to
>> check for a separate flag. It's not ideal, but until we separate regset
>> handling into an appropriate vector, it's the best we can do (I think).
>>
>> OK?
>
>
> Well, I like it (and thanks for working on it),
> but Andrew might have something to say about adding
> a new macro. Andrew?
>> * config/i386/tm-linux.h: Define FILL_FPXREGSET.
linux-proc.c is only built native so I think FILL_.. should only be
defined for native builds => config/i386/nm-linux.h.
Having #ifdef code enabled via a tm.h file macro just feels wrong.
enjoy,
Andrew