This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix mi-break.exp: 'b "basics.c":16'


Daniel Jacobowitz writes:
> But for "basics.c":16, *p == ':'.  So the quote is actually copied.

Okay, I understand now.  *p points to the delimiter, not to the '"'.
The earlier lines:

      if ((*p == '"') && is_quote_enclosed)
	--p;

are actually the anomalous lines.

What a mess.  I'm glad that your patch is removing net lines.
Maybe someday somebody can rewrite this mess.

My preliminary results on one configuration are the same as yours:
fixes four FAILs in gdb.mi, no regressions.  My test bed is about
50% done.  Results in an hour or so.

Michael C


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]