Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI

[Jim Blandy <jimb at redhat dot com>]

Daniel Berlin <dan@dberlin.org> writes:
> On 26 Mar 2002, Jim Blandy wrote:
> > Actually, Daniel, I'm sorry --- I've re-read the change more
> > carefully, and I've gotten more confused than I was before.
> > 
> > You've changed the Dwarf 2 location expression evaluator to consult
> > the current register values --- not the values of the registers with
> > respect to a specific stack frame.  I can't think of any situations in
> > which this the correct behavior.  Can you explain more about the
> > contexts in which this change is useful?  It seems to me that it's
> > wrong in most of the cases I can think of.  It really needs to take a
> > frame argument, or at the very least, read registers from the selected
> > frame (although that's kind of gross and global-variable-ish).
> 
> Whoops.
> You're right.
> I must have merged it while on crack or something.
> I *meant* to add the frame argument, and only require *either* the 
> context argument (Which is what it currently takes, a CFA context)  or the 
> frame, but it looks like I messed up.
> 
> What it *should* look like is closer to the one from the WIP i sent. It 
> should call get_saved_register with the frame argument if the context is 
> null, or get_reg with the context argument if the context is not null.

Okay --- that makes more sense.

I started reviewing the WIP, but I got interrupted.  Do you want to
extract something from that and post it as a non-WIP patch?