This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] x86_64_skip_prologue
> Kevin Buettner wrote:
> 3) Now pc points to the first line of the sourcecode of the function (usually opening '{'). If the next line with debuginfo has pc within bounds of this function, we will return this pc instead.
>
> You might want to take a look at some of the other prologue analyzers.
> In particular, you might want to consider calling find_pc_line() instead
> of accessing the data structures directly.
>
> Most of other *_skip_prologue functions pretend, that prolog is an always-the-same sequence of instructions, what is not the case on x86-64. I can't see an approach other than the one I have chosen.
> Of course I can use other structures and maybe some macros, but the concept will remain. Or is there another way?
>
> Why should I preferably use find_pc_line()? It gives me the same symtab as find_pc_symtab() does... Anyway I have rewritten the code to use it.
>
> BTW, you might want to run your code through indent.
>
> Sorry, I'm not yet used to follow GNU coding style. Hopefully now it is better ;-)
> Michal Ludvig
The script gdb_indent.sh will always fix any problems :-)
Yes, ok. (Don't forget the changelog when posting patches).
Andrew