This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] gdb_realpath causes problems with GVD


Joel,

I suspect you're right.

Two comments:

I think gdb_realpath() needs a re-name - it no longer implements 
realpath() semantics.  xfullpath() comes to mind (`x' for `xmalloc', 
`fullpath' cos it is close to realpath :-) (Better ideas? Does libiberty 
already provide an equivalent?)

I don't think trying to rewriting the gdb_realpath() autoconfigury magic 
is a good idea (the rewrite as two comile errors).  Instead just assume 
that gdb_realpath() works and use that, concat() and xfree().  I think 
the first rule of autoconf is, if it ain't `broke' don't fix it :-)(1)

enjoy,
Andrew

(1) Yes, I know, I've got that NULL canonicalize patch to commit :-)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]