This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: x86-64-tdep.h cleanup
Kevin Buettner <kevinb@redhat.com> writes:
> On Mar 5, 4:56pm, Michal Ludvig wrote:
>
>> As it was recommended by lots of people here I moved <sys/reg.h> along
>> with regmap from x86-64-tdep.h to x86-64-linux-nat.c.
>> Also to let x86-64-tdep.h contain only #defines, I moved declarations of
>> x86_64_linux_frame_saved_pc and x86_64_linux_saved_pc_after_call to
>> x86-64-tdep.c. Are these changes OK to commit?
>>
>> Michal Ludvig
>>
>> Index: ChangeLog
>> from Michal Ludvig <mludvig@suse.cz>
>>
>> * x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c
>> (x86_64_linux_frame_saved_pc,
>> x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c
>> * x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here
>> from x86-64-tdep.h
>> * x86-64-tdep.c (x86_64_linux_frame_saved_pc,
>> x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h
>
>
> Michael,
>
> I'm not the maintainer of the files in questions, but your changes
> look okay to me.
Since x86-64 is currently not officially (according to GDB
maintainership rules) by anybody, you have the right to ok this
change. Is this an approval?
Thanks,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj