This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] honor new-console and new-group in win32-nat.c


On Fri, Feb 22, 2002 at 11:25:41AM -0500, Christopher Faylor wrote:
>On Fri, Feb 22, 2002 at 09:48:41AM +0100, Pierre Muller wrote:
>>
>>Since the shell patch in win32-nat.c,
>>the new-group and new-console commands are igonred.
>>
>>This is due to a small mistake in  child_create_inferior.
>>
>>The following patch fixed this.
>>If you use new-console, this patch will also expose
>>another problem (not fixed here), which is that the
>>shell is not allowed to exit after exit of the debuggee.
>>
>>Christopher,  shouldn't you set usesshell to 0
>>already so that other people trying to use the cygwin native 
>>from CVS will be able to use it normally until you
>>fix the other problems relative to shell usage.
>>
>>
>>2002-02-22  Pierre Muller  <muller@ics.u-strasbg.fr>
>>
>>	* win32-nat.c (child_create_inferior): Fix create flags setting bug.
>
>Ok.  Please check in.

Actually.  Wait.  There's a better way to do this.  Sorry.

Just get rid of the flags = 0 and move the useshell stuff prior to
the flags |=.  That's what I'd intended to do but muffed the placement
of the useshell conditionals.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]