This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH multi-arch GET_LONGJMP_TARGET



> Thinking about it, the cleanest way to handle this for now is to change 
> the test for a definition of JB_PC, since unless that is defined the code 
> won't compile, and even if it did it would give the wrong answer.
> 
> As far as I can tell, apart from i386, only two further ports define 
> GET_LONGJMP_TARGET: arc and sparc.  Arc seems never to use the code 
> (there's only one .h file for that port and it doesn't define 
> GET_LONGJMP_TARGET or JB_PC); Sparc seems to define it for pretty much all 
> configurations I can think of.
> R.
> 
> <date>  Richard Earnshaw  <rearnsha@arm.com>
> 
> 	* arc-tdep.c (get_longjmp_target): Only compile this function if
> 	JB_PC is defined.
> 	* sparc-tdep.c (get_longjmp_target): Likewise.

I've committed this, given that it was potentially breaking these targets 
by not having this change.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]