Re: [RFA]: Fix FP handling for non-multiarched targets

[Corinna Vinschen <vinschen at redhat dot com>]

On Fri, Feb 08, 2002 at 12:05:55PM -0500, Andrew Cagney wrote:
> >Hi,
> >
> >I'd like to propose the following patch.
> >
> >While running the testsuite on ARM several FP errors happened,
> >which apparently were a result of forcing the wrong FP type
> >on `builtin_type_float' and friends.  This is a result of
> >three lines in gdbtype.c which override the target specific
> >types with another one.  Thanks to Andrew Cagney for helping
> >to track that down.
> 
> 
> Sigh.  This kind of highlights why non- multi-arch targets need to just 
> go away.  It isn't so much that the code override the target type but 
> rather that it is correctly setting it.  On a multi-arch target this is 
> fine - everytime the architecture changes, the builtin_type_float's 
> floatformat is updated.  On a non-multi-arch target though, it it is a 
> disaster.  It is never updated leaving builtin_type_float et.al. with 
> the initial (big-endian?) value.
> 
> Corinna, rather than just delete those lines can you wrap them in #if 0 
> / #endif and then add a comment explaining the need to disable them. 
> Can you then also file a bug report (change request) to record the 
> problem.  Once everything is multi-arch, the code can be re-enabled.

Commited and the CR is filed.

Thanks,
Corinna