This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Support for alpha*-*-netbsd*

>  > alphabsd-nat.c: The changes are approved (separatly) but please change 
>  > the macro GETREGS_SUPPLIES into a function.
> 
> Hm.  It's a macro in a lot of other files, as well.  It's not intended to
> be used outside that source module ... should all the other macro versions
> of it be functions, too?


Sigh, yes, you're the innocent party in all this.  It is why certain 
coding pratices are being agressivly eliminated from GDB - so that 
people don't innocently copy them.

Those same macros in the other files really should be changed to static 
functions (I'm not exactly going to run out and hold my breath waiting 
for it to happen though :-).

http://sources.redhat.com/gdb/onlinedocs/gdbint_13.html#SEC107

Andrew
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]