This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[patch/rfc] rename CLEAN_UP_REGISTER_VALUE to DEPRECATED_...
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Thu, 10 Jan 2002 20:25:03 -0500
- Subject: [patch/rfc] rename CLEAN_UP_REGISTER_VALUE to DEPRECATED_...
Hello,
The attached patch is important. It sets the precident.
Architecture methods that are not going to be multi-archeded can be
renamed to deprecated_... as a stepping stone on their path to
obsolecence. Given the transformation is mechanical, the change is obvious.
The rationale behind this was discussed last year. It was felt that it
wasn't just sufficient to document a macro as deprecated - active steps
were needed - rename the function for instance. Other active steps were
also proposed, (print a warning) but they can be followed up later.
look ok,
Andrew
2002-01-10 Andrew Cagney <ac131313@redhat.com>
* config/pa/tm-hppa.h (DEPRECATED_CLEAN_UP_REGISTER_VALUE): Rename
CLEAN_UP_REGISTER_VALUE.
* regcache.c (supply_register): Update only call.
Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.29
diff -p -r1.29 regcache.c
*** regcache.c 2001/12/07 15:00:59 1.29
--- regcache.c 2002/01/11 01:13:40
*************** supply_register (int regnum, char *val)
*** 571,578 ****
through the method gdbarch_register_read() clean up the
values. */
! #ifdef CLEAN_UP_REGISTER_VALUE
! CLEAN_UP_REGISTER_VALUE (regnum, register_buffer (regnum));
#endif
}
--- 571,578 ----
through the method gdbarch_register_read() clean up the
values. */
! #ifdef DEPRECATED_CLEAN_UP_REGISTER_VALUE
! DEPRECATED_CLEAN_UP_REGISTER_VALUE (regnum, register_buffer (regnum));
#endif
}
Index: config/pa/tm-hppa.h
===================================================================
RCS file: /cvs/src/src/gdb/config/pa/tm-hppa.h,v
retrieving revision 1.11
diff -p -r1.11 tm-hppa.h
*** tm-hppa.h 2002/01/05 04:30:38 1.11
--- tm-hppa.h 2002/01/11 01:13:42
*************** extern CORE_ADDR saved_pc_after_call (st
*** 251,257 ****
clean them up using this macro. BUF is a char pointer to
the raw value of the register in the registers[] array. */
! #define CLEAN_UP_REGISTER_VALUE(regno, buf) \
do { \
if ((regno) == PCOQ_HEAD_REGNUM || (regno) == PCOQ_TAIL_REGNUM) \
(buf)[sizeof(CORE_ADDR) -1] &= ~0x3; \
--- 251,257 ----
clean them up using this macro. BUF is a char pointer to
the raw value of the register in the registers[] array. */
! #define DEPRECATED_CLEAN_UP_REGISTER_VALUE(regno, buf) \
do { \
if ((regno) == PCOQ_HEAD_REGNUM || (regno) == PCOQ_TAIL_REGNUM) \
(buf)[sizeof(CORE_ADDR) -1] &= ~0x3; \