This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix inferior_pid argument for arm-netbsd


On Jan 10,  5:58pm, Richard Earnshaw wrote:

> > > On Jan 9,  1:38pm, Richard Earnshaw wrote:
> > > 
> > > > 	* armnbsd-nat.c (fetch_inferior_registers): Change inferior_pid -> 
> > > > 	inferior_ptid.pid.
> > > 
> > > Please don't do it this way.  Use the accessor functions instead.  I've
> > > looked over your patch, and in each case, you can simply use
> > > 
> > >     ptid_get_pid (inferior_ptid)
> > > 
> > 
> > Ah!  I wasn't aware of the accessor functions.  In fact, most targets are 
> > using the macro GETPID (from defs.h).  I've fixed the code to use that.
> 
> I haven't heard anything further.  Can I assume this is acceptable now, or 
> do I have to go into limbo for another month?

It's fine.  Check it in.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]