This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: port to Sanyo XStormy16 CPU


On Tue, Dec 11, 2001 at 03:16:19PM -0800, Andrew Cagney wrote:
> > Corinna
> > 
> > gdb ChangeLog:
> > 
> > 2001-12-10  Corinna Vinschen  <vinschen@redhat.com>
> > 
> > * Makefile.in: Add support for xstormy16.
> > 	* configure.tgt: Ditto.
> > 	* xstormy16-tdep.c: New file.
> > 	* config/xstormy16/xstormy16.mt: New file.
> > 
> > gdb/testsuite ChangeLog:
> 
> 
> Yes.  Your code is fine.  The comments are very much appreciated.
> 
> Just the usual style things:  can I suggest making macro's like 
> TYPE_IS_SCALAR functions; can you please put the .c files through 
> gdb/gdb_indent.sh so it matches GDB's indentation style.

I've rearranged the macro TYPE_IS_SCALAR() to be a function called
xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c.

Thanks for the approval, I've applied everything.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]