This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] ppc-linux-nat.c: Don't use regmap[] anymore.

From: Andrew Cagney <ac131313 at cygnus dot com>
To: Kevin Buettner <kevinb at redhat dot com>
Cc: Elena Zannoni <ezannoni at cygnus dot com>,gdb-patches at sources dot redhat dot com
Date: Thu, 29 Nov 2001 17:56:31 -0500
Subject: Re: [RFA] ppc-linux-nat.c: Don't use regmap[] anymore.
References: <15362.34742.58613.695856@krustylu.cygnus.com> <1011129205738.ZM19235@ocotillo.lan> <3C06AC88.50403@cygnus.com> <1011129215935.ZM19472@ocotillo.lan>

> On Nov 29,  4:45pm, Andrew Cagney wrote:
> 
> 
>> I suspect a few more targets could do with the same treatment. 
>> Eliminating that hardwired regmap[] would probably help a few more targets.
> 
> 
> Perhaps.  But, I think each target better have good reasons for doing
> so before undertaking such a transformation.  Replacing the hardwired
> regmap[] with a function with the same constants hardwired into it
> doesn't accomplish much (aside from slowing things somewhat).

The problem is, they are not constant.  Because of limitations in the 
way other parts of GDB currently work, an architecture change can cause 
those offsets to change :-(  Check x86-64 vs i386.

I don't think performance is an issue here.

enjoy,
Andrew

References:
- [RFA] ppc-linux-nat.c: Don't use regmap[] anymore.
  - From: Elena Zannoni
- Re: [RFA] ppc-linux-nat.c: Don't use regmap[] anymore.
  - From: Kevin Buettner
- Re: [RFA] ppc-linux-nat.c: Don't use regmap[] anymore.
  - From: Andrew Cagney
- Re: [RFA] ppc-linux-nat.c: Don't use regmap[] anymore.
  - From: Kevin Buettner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]