Re: [RFA 2nd try] tell in which register a register var is loaded.

[Andrew Cagney <ac131313 at cygnus dot com>]

> This patch superseeds the previous one,
> the lval_reg_frame_relative case was not handled correctly there.
> 
> http://sources.redhat.com/ml/gdb-patches/2001-11/msg00301.html
> 
> 
> Still no idea who should give an approval for this patch ?

No one else did so ...

> 2001-11-20 Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>     * findvar.c (locate_var_value): specify in which register a register
>     variable is stored.

Don't forget to ucase ``specify''.

Hmm, can REGISTER_NAME (num) ever be invalid or is this just being careful?

If the latter then can I suggest an assertion vis:

	gdb_assert (REGISTER_NAME (...) != NULL
	            && *REGISTER_NAME (...) != '\0');

If the former then the test will need to be tweeked to check for both 
NULL and '\0'.

Your choice.

I don't think the ``$'' prefix is consistent with existing code - based 
mainly on a quick grep that didn't reveal any code doing this.  (I don't 
actually have anything agains the convention though - just a separate 
change :-)

Otherwize, yes, a much more helpful error message.

enjoy,
Andrew



> Index: findvar.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/findvar.c,v
> retrieving revision 1.25
> diff -u -r1.25 findvar.c
> --- findvar.c    2001/11/10 21:34:56    1.25
> +++ findvar.c    2001/11/20 17:04:06
> @@ -869,8 +869,20 @@
>    switch (VALUE_LVAL (lazy_value))
>      {
>      case lval_register:
> +      if (REGISTER_NAME (VALUE_REGNO (lazy_value)))
> +       error("Address requested for identifier \"%s\" which is in register $%s",
> +            SYMBOL_SOURCE_NAME (var), REGISTER_NAME (VALUE_REGNO (lazy_value)));
> +      else
> +       error ("Address requested for identifier \"%s\" which is in a register.",
> +         SYMBOL_SOURCE_NAME (var));
> +      break;
> +
>      case lval_reg_frame_relative:
> -      error ("Address requested for identifier \"%s\" which is in a register.",
> +      if (REGISTER_NAME (VALUE_FRAME_REGNUM (lazy_value)))
> +       error("Address requested for identifier \"%s\" which is in frame register $%s",
> +            SYMBOL_SOURCE_NAME (var), REGISTER_NAME (VALUE_FRAME_REGNUM (lazy_value)));
> +      else
> +       error ("Address requested for identifier \"%s\" which is in a register.",
>           SYMBOL_SOURCE_NAME (var));
>        break;
>