Re: [PATCH] simulator for mips3264

["Eric M. Christopher" <echristo at redhat dot com>]

> And now the tables are turned!  Muhahahahaha!  8-)

> So, the issues / questions:
> 
> (1) "using how?" / "tested how?"
> 

I deserved that one.  I really did ;)

mipsisa32-elf gcc. Internal port for another chip. Using it as a
simulator for execution testing for gcc.

> (2) why bother define the do_foo functions in m3264.igen, when they're
>     only used in one function?
> 

Infrastructure.  May need them again some day.

> (3) why did you add clo/clz in mips.igen?  I know there are some
>     non-true-mips32/mips64 CPUs which implement them...  but they also
>     implement madd/maddu/msub/msubu.  Any argument that puts these in
>     mips.igen also puts the rest, as far as I can see.
> 

Ok. I can do this...

>     Personally, if I were doing this ("oh wait, we did, but I've not
>     had time to go back and submit it all yet!" 8-) I'd put the new
>     mips32/mips64 instructions into mips.igen, since they're neither
>     particular chip-specific and they're not an ASE either.
> 

Or this.  Pick one :)


> (4) you're missing dclo + dclz.
> 

Got one for me? ;)

> (5) the diff looks like you're implement {mf,mt}{lo,hi} w/ hazards as
>     needed for early MIPS.  Is that correct?  (MIPS32/MIPS64 and
>     indeed back to MIPS IV, didn't have that restriction.  Looks like
>     the code was incorrect for MIPS IV previously, according to the
>     MIPS64 BIS doc.)

I'll read the spec again and update. This was implemented to an old
version of the mips32 spec. Perhaps there's an error in there.

-eric

-- 
Fridays are not "pants optional"