This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/expect] Add explicit build rules for tcl_regexp.c
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: [rfa/expect] Add explicit build rules for tcl_regexp.c
- From: Ian Roxborough <irox at redhat dot com>
- Date: Sat, 22 Sep 2001 00:43:32 -0700
- CC: gdb-patches at sources dot redhat dot com, insight at sources dot redhat dot com
- References: <3BAA4DE7.5060702@cygnus.com>
Approved.
THanks,
Ian.
Andrew Cagney wrote:
>
> Hello,
>
> I was finding that I couldn't build the expect in the CVS repository on
> a FreeBSD machine - expect/tcl_regexp.c was failing because it was
> including tcl/.../unistd.h instead of <unistd.h>. This was occuring
> because HAVE_UNISTD_H wasn't defined.
>
> The attached patch adds an explicit compile rule for tcl_regexp.c that
> includes all the autoconf -D... flags (esp HAVE_UNISTD_H) and hence
> (appears to) fix the problem
>
> Ok?
> Andrew
>
> --------------------------------------------------------------------------------
> Thu Sep 20 16:00:44 2001 Andrew Cagney <cagney@b1.cygnus.com>
>
> * Makefile.in (shared/tcl_regexp.o, tcl_regexp.o): Add explict
> build rules that include @TCL_DEFS@ in the list of compiler flags.
>
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/expect/Makefile.in,v
> retrieving revision 1.3
> diff -p -r1.3 Makefile.in
> *** Makefile.in 2001/09/08 06:26:30 1.3
> --- Makefile.in 2001/09/20 20:03:06
> *************** pty_sgttyb.o: $(srcdir)/pty_sgttyb.c exp
> *** 848,850 ****
> --- 848,855 ----
> pty_termios.o: $(srcdir)/pty_termios.c expect_cf.h exp_win.h \
> exp_tty_in.h exp_tty.h exp_rename.h exp_pty.h
> pty_unicos.o: $(srcdir)/pty_unicos.c expect_cf.h exp_rename.h
> + tcl_regexp.o: $(srcdir)/tcl_regexp.c
> + $(CC) -c $(CFLAGS_INT) @TCL_DEFS@ $(HDEFS) $<
> + shared/tcl_regexp.o: $(srcdir)/tcl_regexp.c
> + $(CC) -c $(CFLAGS_INT) @EXP_SHLIB_CFLAGS@ @TCL_DEFS@ $(HDEFS) $< -o shared/$@
> +