This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: x86_64 target - multiarch
- To: Jiri Smid <smid at suse dot cz>
- Subject: Re: [RFA]: x86_64 target - multiarch
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Date: Tue, 11 Sep 2001 14:44:29 +0200 (IST)
- cc: gdb-patches at sources dot redhat dot com, Mark Kettenis <kettenis at science dot uva dot nl>
On 11 Sep 2001, Jiri Smid wrote:
> *** 466,472 ****
> {
> int retval;
>
> ! if (len == 3 || len > 4 || addr % len != 0)
> retval = i386_handle_nonaligned_watchpoint (WP_INSERT, addr, len, type);
> else
> {
> --- 481,488 ----
> {
> int retval;
>
> ! if ((len != 1 && len !=2 && len !=4 && (TARGET_HAS_DR_LEN_8 && len !=8))
> ! || addr % len != 0)
> retval = i386_handle_nonaligned_watchpoint (WP_INSERT, addr, len, type);
> else
> {
Unless I'm missing something, the new code loses if addr and len both
equal to 3, for a target which does not define TARGET_HAS_DR_LEN_8. I
think this is better:
if ((len != 1 && len !=2 && len !=4 && !(TARGET_HAS_DR_LEN_8 && len ==8))
(There's one more case like this.)
Other than that, I have no comments.