This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [rfc/rfa(DavidT?)] Move DOUBLEST to doublest.{h,c}


> Headers such as tm-m88k.h contain macros that refer to functions such as    store_floating().  I moved those functions to doublest.h.
> 
> I see, but how about the i386/xm-*.h files?  I'm asking since I'm
> thinking about replacing most of them with a single xm-i386.h with the
> following contents:
> 
> 
> I was only checking for references to the functions I moved.


Hmm, oops no, sorry, not quite...


>    /* FIXME: kettenis/2001-07-29: Get rid of HOST_BYTE_ORDER when Andrew
>       has erradicated it from the sources.  */
>    #define HOST_BYTE_ORDER LITTLE_ENDIAN
> 
>    #define HOST_FLOAT_FORMAT &floatformat_ieee_single_little
>    #define HOST_DOUBLE_FORMAT &floatformat_ieee_double_little
>    #define HOST_LONG_DOUBLE_FORMAT &floatformat_i387_ext
> 
> 
> I'd include "floatformat.h".  Is there an x86 system that doesn't have long double?  I've a memory of someone pointing this out when I recently  changed the i387 float conversion code.


I was incorrectly adding a #include "doublest.h" when the file defined 
(not used) things like HOST_FLOAT_FORMAT.  Further cross checking 
reveals that I also missed a few DOUBLEST references ;-/

I'll revise and repost.

	Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]