This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Fix i386 FPU register conversion code


Andrew Cagney wrote:
> 
> > Hmm, when I added the assertion, I was under the impression that if
> > the virtual type wasn't a floating-point type it would be a GDB
> > internal error, hence the gdb_assert.  However, this is probably not
> > entirely true, since I now think that bogus debug information (e.g. a
> > stab that says that  an integer variable that lives in a
> > floating-point register) might trip the assertion.  Printing a warning
> > and returning without doing anything is probably better.
> 
> By ``nothing'' I guess you mean do something like zero the destination
> buffer :-)

Right.  Silently fix it up, rather than call abort.
Some errors don't warrant terminating a possibly long
debug session.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]