This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Add remote P packet handling to GDBSERVER


I am back from my a very vital trip.  However, my medical condition is 
(again) becoming a problem.  I may be back in the hospital for additional
weeks any day.   

On Wednesday 11 July 2001 00:47, Andrew Cagney wrote:
> >  The following patch add 'P' packet handling to GDBSERVER
> > 	and does some code clean-up.  This patch replaces my
> > 	GDBSERVER patch of April 26 at:
> >
> > http://sources.redhat.com/ml/gdb-patches/2001-04/msg00256.html
>
> John, as you note, this contains two changes:
>
> 	o	cleanups
> 	o	addition of the `P' packet
>
> could you please split out the cleanup and submit that (first) separately
> (See also notes below on ChangeLog entries).  Trying to break patches
> down to separate independant changes is really important.  There are

I will break this into three patches.  
  -First patch, code file reformate with indent v2.2.6  with default setting. 
  -Second code cleanups.  
  -Last patch, addition of 'P' packet to gdbserver code.  

Each patch to depend on the prior patch and each patch reformated with 
default setting of indent v2.2.6.  If the default 'C' coding style is the 
current default of GNU indent, I think that you have a lot of source code 
reformatting to do within the gdb source files.

The code cleanup patch is a modified version of the un-approved patch in 
message http://sources.redhat.com/ml/gdb-patches/2001-04/msg00256.html.
So yes the code cleanups change was sent as a separate patch!  When the
code clean patch was ignored, I just included it with my next patch in that 
area of gdbserver code. 



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]