This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH]: More tui cleanup
- To: gdb-patches at sources dot redhat dot com
- Subject: [PATCH]: More tui cleanup
- From: Stephane Carrez <Stephane dot Carrez at worldnet dot fr>
- Date: Sat, 21 Jul 2001 00:32:31 +0200
Hi!
More tui cleanup:
- remove some unused functions (the varargs functions)
- remove tuiStrDup to use xstrdup instead.
- call tui_enable() for the commands so that it switches
to the TUI when these commands are called.
Stephane
2001-07-21 Stephane Carrez <Stephane.Carrez@worldnet.fr>
* tuiSourceWin.h: Remove unused declarations.
* tuiSourceWin.c (tui_vUpdateSourceWindowsWithAddr): Remove.
(tui_vUpdateSourceWindowsWithLine): Remove.
(tui_vAllSetHasBreakAt): Remove.
* tuiLayout.h (tui_set_layout): Declare.
(tui_vSetLayoutTo): Remove.
(tui_vAddWinToLayout): Remove.
* tuiLayout.c (_tuiLayout_command): Call tui_enable() to force TUI.
(_tuiToggleLayout_command): Remove.
(_tuiToggleSplitLayout_command): Remove.
(_tuiLayout_command): Remove.
(tui_vSetLayoutTo): Remove.
(tui_vAddWinToLayout): Remove.
* tuiDataWin.h (tui_vCheckDataValues): Remove.
* tuiDataWin.c (tui_vCheckDataValues): Remove.
Index: tuiSourceWin.h
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiSourceWin.h,v
retrieving revision 1.5
diff -u -p -r1.5 tuiSourceWin.h
--- tuiSourceWin.h 2001/07/18 20:59:00 1.5
+++ tuiSourceWin.h 2001/07/20 22:24:40
@@ -28,9 +28,7 @@ extern void tuiUpdateSourceWindow (TuiWi
extern void tuiUpdateSourceWindowAsIs (TuiWinInfoPtr, struct symtab *, Opaque,
int);
extern void tuiUpdateSourceWindowsWithAddr (CORE_ADDR);
-extern void tui_vUpdateSourceWindowsWithAddr (va_list);
extern void tuiUpdateSourceWindowsWithLine (struct symtab *, int);
-extern void tui_vUpdateSourceWindowsWithLine (va_list);
extern void tuiUpdateSourceWindowsFromLocator (void);
extern void tuiClearSourceContent (TuiWinInfoPtr, int);
extern void tuiClearAllSourceWinsContent (int);
@@ -56,7 +54,6 @@ extern void tuiUpdateAllExecInfos (void)
extern void tuiSetIsExecPointAt (Opaque, TuiWinInfoPtr);
extern void tuiSetHasBreakAt (struct breakpoint *, TuiWinInfoPtr, int);
extern void tuiAllSetHasBreakAt (struct breakpoint *, int);
-extern void tui_vAllSetHasBreakAt (va_list);
extern TuiStatus tuiAllocSourceBuffer (TuiWinInfoPtr);
extern int tuiLineIsDisplayed (Opaque, TuiWinInfoPtr, int);
@@ -65,29 +62,6 @@ extern int tuiLineIsDisplayed (Opaque, T
** Constant definitions
*/
#define SCROLL_THRESHOLD 2 /* threshold for lazy scroll */
-
-
-/*
- ** Macros
- */
-#define m_tuiSetBreakAt(bp, winInfo) tuiSetHasBreakAt((bp, winInfo, TRUE)
-#define m_tuiClearBreakAt(bp, winInfo) tuiSetHasBreakAt(bp, winInfo, FALSE)
-
-#define m_tuiAllSetBreakAt(bp) tuiAllSetHasBreakAt(bp, TRUE)
-#define m_tuiAllClearBreakAt(bp) tuiAllSetHasBreakAt(bp, FALSE)
-
-#define m_tuiSrcLineDisplayed(lineNo) tuiLineIsDisplayed((Opaque)(lineNo), srcWin, FALSE)
-#define m_tuiSrcAddrDisplayed(addr) tuiLineIsDisplayed((Opaque)(addr), disassemWin, FALSE)
-#define m_tuiSrcLineDisplayedWithinThreshold(lineNo) \
- tuiLineIsDisplayed((Opaque)(lineNo), srcWin, TRUE)
-#define m_tuiSrcAddrDisplayedWithinThreshold(addr) \
- tuiLineIsDisplayed((Opaque)(addr), disassemWin, TRUE)
-#define m_tuiLineDisplayedWithinThreshold(winInfo, lineOrAddr) \
- ( (winInfo == srcWin) ? \
- m_tuiSrcLineDisplayedWithinThreshold(lineOrAddr) : \
- m_tuiSrcAddrDisplayedWithinThreshold(lineOrAddr) )
-
-
#endif
/*_TUI_SOURCEWIN_H */
Index: tuiSourceWin.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiSourceWin.c,v
retrieving revision 1.5
diff -u -p -r1.5 tuiSourceWin.c
--- tuiSourceWin.c 2001/07/18 20:59:00 1.5
+++ tuiSourceWin.c 2001/07/20 22:24:42
@@ -217,23 +217,7 @@ tuiUpdateSourceWindowsWithAddr (CORE_ADD
return;
} /* tuiUpdateSourceWindowsWithAddr */
-
/*
- ** tui_vUpdateSourceWindowsWithAddr()
- ** Update the source window with the address in a va_list
- */
-void
-tui_vUpdateSourceWindowsWithAddr (va_list args)
-{
- Opaque addr = va_arg (args, Opaque);
-
- tuiUpdateSourceWindowsWithAddr (addr);
-
- return;
-} /* tui_vUpdateSourceWindowsWithAddr */
-
-
-/*
** tuiUpdateSourceWindowsWithLine().
** Function to ensure that the source and/or disassemly windows
** reflect the input address.
@@ -263,23 +247,6 @@ tuiUpdateSourceWindowsWithLine (struct s
return;
} /* tuiUpdateSourceWindowsWithLine */
-
-/*
- ** tui_vUpdateSourceWindowsWithLine()
- ** Update the source window with the line number in a va_list
- */
-void
-tui_vUpdateSourceWindowsWithLine (va_list args)
-{
- struct symtab *s = va_arg (args, struct symtab *);
- int line = va_arg (args, int);
-
- tuiUpdateSourceWindowsWithLine (s, line);
-
- return;
-} /* tui_vUpdateSourceWindowsWithLine */
-
-
/*
** tuiClearSourceContent().
*/
@@ -557,24 +524,6 @@ tuiAllSetHasBreakAt (struct breakpoint *
} /* tuiAllSetHasBreakAt */
-/*
- ** tui_vAllSetHasBreakAt()
- ** Set or clear the hasBreak flag in all displayed source windows,
- ** with params in a va_list
- */
-void
-tui_vAllSetHasBreakAt (va_list args)
-{
- struct breakpoint *bp = va_arg (args, struct breakpoint *);
- int hasBreak = va_arg (args, int);
-
- tuiAllSetHasBreakAt (bp, hasBreak);
-
- return;
-} /* tui_vAllSetHasBreakAt */
-
-
-
/*********************************
** EXECUTION INFO FUNCTIONS **
*********************************/
@@ -769,7 +718,7 @@ tuiUpdateExecInfo (TuiWinInfoPtr winInfo
{
tuiSetExecInfoContent (winInfo);
tuiShowExecInfoContent (winInfo);
-} /* tuiUpdateExecInfo
+} /* tuiUpdateExecInfo */
/*
Index: tuiLayout.h
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiLayout.h,v
retrieving revision 1.3
diff -u -p -r1.3 tuiLayout.h
--- tuiLayout.h 2001/07/14 19:01:25 1.3
+++ tuiLayout.h 2001/07/20 22:24:42
@@ -24,10 +24,9 @@
extern void showLayout (TuiLayoutType);
extern void tuiAddWinToLayout (TuiWinType);
-extern void tui_vAddWinToLayout (va_list);
extern int tuiDefaultWinHeight (TuiWinType, TuiLayoutType);
extern int tuiDefaultWinViewportHeight (TuiWinType, TuiLayoutType);
+extern TuiStatus tui_set_layout (const char *);
extern TuiStatus tuiSetLayout (TuiLayoutType, TuiRegisterDisplayType);
-extern TuiStatus tui_vSetLayoutTo (va_list);
#endif /*TUI_LAYOUT_H */
Index: tuiLayout.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiLayout.c,v
retrieving revision 1.12
diff -u -p -r1.12 tuiLayout.c
--- tuiLayout.c 2001/07/19 22:47:46 1.12
+++ tuiLayout.c 2001/07/20 22:24:44
@@ -55,9 +55,7 @@ static TuiLayoutType _nextLayout (void);
static TuiLayoutType _prevLayout (void);
static void _tuiLayout_command (char *, int);
static void _tuiToggleLayout_command (char *, int);
-static void _tui_vToggleLayout_command (va_list);
static void _tuiToggleSplitLayout_command (char *, int);
-static void _tui_vToggleSplitLayout_command (va_list);
static CORE_ADDR _extractDisplayStartAddr (void);
static void _tuiHandleXDBLayout (TuiLayoutDefPtr);
@@ -275,23 +273,6 @@ tuiSetLayout (TuiLayoutType layoutType,
return status;
} /* tuiSetLayout */
-
-/*
- ** tui_vSetLayoutTo()
- ** Function to set the layout to SRC, ASM, SPLIT, NEXT, PREV, DATA,
- ** REGS, $REGS, $GREGS, $FREGS, $SREGS with arguments in a va_list
- */
-TuiStatus
-tui_vSetLayoutTo (va_list args)
-{
- char *layoutName;
-
- layoutName = va_arg (args, char *);
-
- return (_tuiSetLayoutTo (layoutName));
-} /* tui_vSetLayoutTo */
-
-
/*
** tuiAddWinToLayout().
** Add the specified window to the layout in a logical way.
@@ -348,22 +329,6 @@ tuiAddWinToLayout (TuiWinType type)
/*
- ** tui_vAddWinToLayout().
- ** Add the specified window to the layout in a logical way,
- ** with arguments in a va_list.
- */
-void
-tui_vAddWinToLayout (va_list args)
-{
- TuiWinType type = va_arg (args, TuiWinType);
-
- tuiAddWinToLayout (type);
-
- return;
-} /* tui_vAddWinToLayout */
-
-
-/*
** tuiDefaultWinHeight().
** Answer the height of a window. If it hasn't been created yet,
** answer what the height of a window would be based upon its
@@ -482,7 +447,7 @@ tui_set_layout (const char *layoutName)
TuiRegisterDisplayType dpyType = TUI_UNDEFINED_REGS;
TuiLayoutType curLayout = currentLayout ();
- bufPtr = (char *) tuiStrDup (layoutName);
+ bufPtr = (char *) xstrdup (layoutName);
for (i = 0; (i < strlen (layoutName)); i++)
bufPtr[i] = toupper (bufPtr[i]);
@@ -628,6 +593,8 @@ _tuiToggleLayout_command (char *arg, int
{
TuiLayoutDefPtr layoutDef = tuiLayoutDef ();
+ /* Make sure the curses mode is enabled. */
+ tui_enable ();
if (layoutDef->displayMode == SRC_WIN)
layoutDef->displayMode = DISASSEM_WIN;
else
@@ -644,6 +611,8 @@ _tuiToggleSplitLayout_command (char *arg
{
TuiLayoutDefPtr layoutDef = tuiLayoutDef ();
+ /* Make sure the curses mode is enabled. */
+ tui_enable ();
layoutDef->split = (!layoutDef->split);
_tuiHandleXDBLayout (layoutDef);
@@ -653,6 +622,10 @@ _tuiToggleSplitLayout_command (char *arg
static void
_tuiLayout_command (char *arg, int fromTTY)
{
+ /* Make sure the curses mode is enabled. */
+ tui_enable ();
+
+ /* Switch to the selected layout. */
if (tui_set_layout (arg) != TUI_SUCCESS)
warning ("Invalid layout specified.\n%s", LAYOUT_USAGE);
Index: tuiDataWin.h
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiDataWin.h,v
retrieving revision 1.3
diff -u -p -r1.3 tuiDataWin.h
--- tuiDataWin.h 2001/07/14 19:01:25 1.3
+++ tuiDataWin.h 2001/07/20 22:24:44
@@ -35,7 +35,6 @@
extern void tuiEraseDataContent (char *);
extern void tuiDisplayAllData (void);
extern void tuiCheckDataValues (struct frame_info *);
-extern void tui_vCheckDataValues (va_list);
extern void tuiDisplayDataFromLine (int);
extern int tuiFirstDataItemDisplayed (void);
extern int tuiFirstDataElementNoInLine (int);
Index: tuiDataWin.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tuiDataWin.c,v
retrieving revision 1.3
diff -u -p -r1.3 tuiDataWin.c
--- tuiDataWin.c 2001/07/14 19:31:09 1.3
+++ tuiDataWin.c 2001/07/20 22:24:46
@@ -22,6 +22,7 @@
#include "defs.h"
#include "tui.h"
#include "tuiData.h"
+#include "tuiGeneralWin.h"
#include "tuiRegs.h"
@@ -294,22 +295,6 @@ tuiCheckDataValues (struct frame_info *f
}
}
} /* tuiCheckDataValues */
-
-
-/*
- ** tui_vCheckDataValues().
- ** Function to check the data values and hilite any that have
- ** changed with args in a va_list
- */
-void
-tui_vCheckDataValues (va_list args)
-{
- struct frame_info *frame = va_arg (args, struct frame_info *);
-
- tuiCheckDataValues (frame);
-
- return;
-} /* tui_vCheckDataValues */
/*