This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [rfa] mips argument passing fixes for o32


> The shift fix matches this
> comment in GCC and is not really specified by the ABI document:


> -		      && TARGET_BYTE_ORDER == BIG_ENDIAN
> +		      && (TARGET_BYTE_ORDER == BIG_ENDIAN
> +			  || TYPE_LENGTH (arg_type) < MIPS_SAVED_REGSIZE)
> 

I don't think this change is right.  In little endian mode, a one byte 
struct will end up being stored at A+4 instead of A.

Which failures did it appear to fix?  Which endian is MIPS/Linux?

	Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]