This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] sparc-nat.c should not include itself


Kevin Buettner wrote:
> 
> I've just checked in the patch below under the "obvious-fix" rule.  I've
> tested this patch on sparc-sun-sunos4.1.4.
> 
>         * sparc-nat.c (sparc-nat.c): Don't include.

The changelog comment is a little terse.  How about "Don't include self"?
Otherwise it might not be clear to future generations what the change was.

> 
> Index: sparc-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/sparc-nat.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 sparc-nat.c
> --- sparc-nat.c 2001/03/01 01:39:21     1.6
> +++ sparc-nat.c 2001/03/02 16:56:53
> @@ -23,7 +23,6 @@
>  #include "inferior.h"
>  #include "target.h"
>  #include "gdbcore.h"
> -#include "sparc-nat.c"
>  #include "regcache.h"
> 
>  #include <signal.h>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]