This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Start abstraction of C++ abi's


Looks like a good idea to me.  "set demangle" currently shows five
different styles (gnu, lucid, arm, hp, edg).  We know that gnu encompasses
two different manglers by itself.  We gotta move these things into
virtual functions.

I won't comment on the directory structure (cp/cp-abi versus cp-abi);
maybe a maintainer would like to think about that.

Some specific comments:

> ! 		   constructor_prefix_p (physname) 
> ! 		   || destructor_prefix_p (physname)
> ! 		   || STREQN (method_name, "~", 1);

Does that lingering STREQN have to be there?

>   		  demangled_name =
>   		    cplus_demangle (mangled_name,
> ! 				    DMGL_ANSI | DMGL_PARAMS | DMGL_VERBOSE);

This looks like you mixed in a bit from a different patch -- there is no
DMGL_VERBOSE in the gdb cvs tree yet.

Beyond that I haven't proof-read the code yet.

Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]