RE: [PATCH]: Fix ser-go32.c for UARTs with FIFOs.

["Francisco Pastor" <fpastor dot etra-id at etra dot es>]

----- Original Message -----
From: Eli Zaretskii <eliz@is.elta.co.il>
To: <ac131313@cygnus.com>
Cc: <gdb-patches@sourceware.cygnus.com>; <fpastor.etra-id@etra.es>
Sent: Tuesday, February 06, 2001 9:53 AM
Subject: Re: [PATCH]: Fix ser-go32.c for UARTs with FIFOs.


> > Date: Mon, 05 Feb 2001 19:13:19 -0800
> > From: Andrew Cagney <ac131313@cygnus.com>
> >
> > Eli Zaretskii wrote:
> > >
> > > FYI: I committed today the following patch:
> > >
> > > 2001-02-04  Eli Zaretskii  <eliz@is.elta.co.il>
> > >
> > >         * ser-go32.c (dos_write) [UART_FIFO_WORKS]: Use outportsb only
if
> > >         UART_FIFO_WORKS is defined.  Otherwise use outportb.
> > >         From Francisco Pastor <fpastor.etra-id@etra.es>
> >
> > Eli, would it be better to make this a run-time option?
>
> You mean, introduce a new interactive command, or an option for an
> existing command?
>
> If you think this would be a good idea, I'll put that on my todo (I
> have a few much more important issues to deal with, such as the
> unified handling of hardware-assisted watchpoints and breakpoints for
> x86, which I promised a long time ago, as well as a few bugs).
>
> It didn't seem to me as a grave problem to make this a compile-time
> option because I don't think the speed we gain by using OUTS vs OUT is
> significant.  (I also cannot test this code on my machine, since I
> don't have a serial link set up.)
>

The problem with OUTS only happen with NT DOS console, not with true DOS
6.22. So, I think that a general solution is leave the patch with a compile
time option or, perhaps, test the DOS version for avoid the use of OUTS. I
donīt think that introduce a new interactive command be a good solution.