This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA] testsuite/gdb.c++/templates.cc printf() patch
> Okay. It's gone. I've appended the patch that I used to "scrap it"
> below. Note that there are now a number of blank lines where the
> printf() definition used to be. I did it that way because it appears
> that there's at least one place in gdb.c++/templates.exp which depends
> on an exact (later) line number. (Search for "b 770".) I think this
> is the only occurrence that would need to be fixed if the lines were
> actually removed, but I wasn't absolutely sure. Also, the testsuite
> results didn't change regardless of whether I blanked or deleted the
> printf() lines, which made me even more reluctant to delete them.
> (I would've felt better about it if the results would've changed when
> I deleted the lines and then changed back again when I adjusted the
> templates.exp code. But since I couldn't get that to happen, I chose
> the more conservative course of action.)
Those lines should probably mention that they are intentionally left
blank....
Andrew