This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH]: memory region attributes
On Fri, Jan 26, 2001 at 11:13:15AM -0500, Christopher Faylor wrote:
>On Tue, Jan 23, 2001 at 12:11:01PM -0800, J.T. Conklin wrote:
>>Since these changes have been on the table for a few months with no
>>objections, I'm going to use my newfound status to commit them.
>>
>>This shouldn't cause any problems or undue overhead when no memory
>>regions are defined. In the past, I've run this through the test-
>>suite with no regressions.
>>
>>Within a week or so, I'll be proposing a remote protocol/remote.c
>>change to support the memory access width attribute.
>
>J.T.,
>FYI, you didn't seem to have changed child_xfer_memory in win32-nat.c
>with this patch. Was that just an oversight?
>
>I'm only mentioning it because I thought there might be other affected
>targets.
I've checked in the patch below.
cgf
2000-01-27 Christopher Faylor <cgf@cygnus.com>
* win32-nat.c (child_xfer_memory): Add missing argument required by
2001-01-23 change.
Index: win32-nat.c
===================================================================
RCS file: /cvs/uberbaum/gdb/win32-nat.c,v
retrieving revision 1.19
diff -u -p -r1.19 win32-nat.c
--- win32-nat.c 2001/01/25 22:35:01 1.19
+++ win32-nat.c 2001/01/27 19:31:40
@@ -1228,7 +1228,8 @@ child_stop (void)
int
child_xfer_memory (CORE_ADDR memaddr, char *our, int len,
- int write, struct target_ops *target ATTRIBUTE_UNUSED)
+ int write, struct mem_attrib *mem ATTRIBUTE_UNUSED,
+ struct target_ops *target ATTRIBUTE_UNUSED)
{
DWORD done;
if (write)