This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] strdup->xstrdup


On Jan 25,  7:53am, Jeff Holcomb wrote:

> 2001-01-24  Jeff Holcomb  <jeffh@redhat.com>
> 
>         * remote-udi.c (udi_open): Change strdup to xstrdup.
>         * thread.c (thread_apply_all_command): Change strdup to xstrdup.
>         Update copyright message.
>         * varobj.c (delete_variable_1): Likewise.
> 
>         * gdb_string.h: Remove declaration of strdup.  Update copyright
>         message.
>         * config/xm-mpw.h: Likewise.
>         * config/i386/xm-i386mach.h: Likewise.
>         * config/m68k/xm-apollo68b.h: Likewise.
>         * config/m68k/xm-hp300bsd.h: Likewise.
>         * config/rs6000/xm-rs6000.h: Likewise.
>         * config/vax/xm-vaxult.h: Remove declaration of strdup.
>         * config/vax/xm-vaxult2.h: Likewise.

These changes look okay, except...

> Index: config/m68k/xm-hp300bsd.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/m68k/xm-hp300bsd.h,v
> retrieving revision 1.2
> diff -u -p -r1.2 xm-hp300bsd.h
> --- xm-hp300bsd.h	2000/05/28 01:12:36	1.2
> +++ xm-hp300bsd.h	2001/01/25 15:27:32
> @@ -1,5 +1,5 @@
>  /* Parameters for hosting on a Hewlett-Packard 9000/300, running bsd.
> -   Copyright 1986, 1987, 1989, 1991, 1992, 1993  Free Software Foundation, Inc.
> +   Copyright 1986, 1987, 1989, 1991, 1992, 1993, 2001  Free Software Foundation, Inc.
>  
>     This file is part of GDB.
>  

...you are no longer removing the strdup() declaration from this file
as you indicate in your ChangeLog entries.  (Your earlier patch did
remove this declaration.)

Kevin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]