Re: [RFA] implement putchar_filtered()

[Fernando Nasser <fnasser at cygnus dot com>]

Sure.

Thanks.

P.S.: I will be moving things to that file as we get rid of the dependencies
in libgdb.


Nick Duffek wrote:
> 
> On 3-Jan-2001, Fernando Nasser wrote:
> 
> >I have an idea: let's add it to the cli.  If it is on a cli header only cli
> >code will be able to use it.
> 
> >Feel free to start a cli/cli-utils.[ch] and add the include on your file.
> 
> ChangeLog:
> 
>         * Makefile.in (SUBDIR_CLI_OBS): Add cli/cli-utils.o.
>         (SUBDIR_CLI_SRCS): Add cli/cli-utils.c.
>         (cli_utils_h): New variable.
>         (cli/cli-utils.o): New rule.
>         * cli/cli-utils.c: New file.
>         * cli/cli-utils.h: New file.
> 
> No regressions on i686-pc-linux-gnu.  Okay?
> 
> Nick
> 
> [patch follows]
> 
> Index: gdb/cli/cli-utils.c
> ===================================================================
> diff -up /dev/null gdb/cli/cli-utils.c
> --- /dev/null   Sun Feb 12 03:29:56 1995
> +++ gdb/cli/cli-utils.c Wed Jan  3 17:16:32 2001
> @@ -0,0 +1,29 @@
> +/* GDB CLI utility library.
> +   Copyright 2001 Free Software Foundation, Inc.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 2 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program; if not, write to the Free Software
> +   Foundation, Inc., 59 Temple Place - Suite 330,
> +   Boston, MA 02111-1307, USA.  */
> +
> +#include "defs.h"
> +#include "cli/cli-utils.h"
> +
> +/* Write character C to gdb_stdout using GDB's paging mechanism and return C.
> +   May return nonlocally.  */
> +
> +int
> +putchar_filtered (int c)
> +{
> +  return fputc_filtered (c, gdb_stdout);
> +}
> Index: gdb/cli/cli-utils.h
> ===================================================================
> diff -up /dev/null gdb/cli/cli-utils.h
> --- /dev/null   Sun Feb 12 03:29:56 1995
> +++ gdb/cli/cli-utils.h Wed Jan  3 17:11:39 2001
> @@ -0,0 +1,27 @@
> +/* Header file for GDB CLI utility library.
> +   Copyright (C) 2001 Free Software Foundation, Inc.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 2 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program; if not, write to the Free Software
> +   Foundation, Inc., 59 Temple Place - Suite 330,
> +   Boston, MA 02111-1307, USA.  */
> +
> +#if !defined (CLI_UTILS_H)
> +# define CLI_UTILS_H 1
> +
> +/* Write character C to gdb_stdout using GDB's paging mechanism and return C.
> +   May return nonlocally.  */
> +
> +extern int putchar_filtered (int c);
> +
> +#endif /* !defined (CLI_UTILS_H) */
> Index: gdb/Makefile.in
> ===================================================================
> diff -up gdb/Makefile.in gdb/Makefile.in
> --- gdb/Makefile.in     Wed Jan  3 17:17:13 2001
> +++ gdb/Makefile.in     Wed Jan  3 17:16:05 2001
> @@ -141,9 +141,10 @@ INTL_CFLAGS = -I$(INTL_DIR) -I$(INTL_SRC
>  # CLI sub directory definitons
>  #
>  SUBDIR_CLI_OBS = \
> -       cli-decode.o cli-script.o cli-cmds.o cli-setshow.o
> +       cli-decode.o cli-script.o cli-cmds.o cli-setshow.o cli-utils.o
>  SUBDIR_CLI_SRCS = \
> -       cli/cli-decode.c cli/cli-script.c cli/cli-cmds.c cli/cli-setshow.c
> +       cli/cli-decode.c cli/cli-script.c cli/cli-cmds.c cli/cli-setshow.c \
> +       cli/cli-utils.c
>  SUBDIR_CLI_DEPS =
>  SUBDIR_CLI_INITS =
>  SUBDIR_CLI_LDFLAGS=
> @@ -604,6 +605,7 @@ cli_decode_h =      $(srcdir)/cli/cli-decode.
>  cli_cmds_h =   $(srcdir)/cli/cli-cmds.h
>  cli_script_h = $(srcdir)/cli/cli-script.h
>  cli_setshow_h =        $(srcdir)/cli/cli-setshow.h
> +cli_utils_h =  $(srcdir)/cli/cli-utils.h
> 
>  # Header files that need to have srcdir added.  Note that in the cases
>  # where we use a macro like $(gdbcmd_h), things are carefully arranged
> @@ -2078,6 +2080,9 @@ cli-script.o: $(srcdir)/cli/cli-script.c
>                 $(cli_cmds_h) $(cli_decode_h) top.h \
>                 $(defs_h) $(value_h) language.h $(ui_out_h)
>         $(CC) -c $(INTERNAL_CFLAGS) $(srcdir)/cli/cli-script.c
> +
> +cli-utils.o: $(srcdir)/cli/cli-utils.c $(cli_utils_h) $(defs_h)
> +       $(CC) -c $(INTERNAL_CFLAGS) $(srcdir)/cli/cli-utils.c
> 
>  #
>  # MI dependencies

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9