This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: PATCH/RFA : m68k_find_saved_regs
- To: Philippe De Muyter <phdm at macqel dot be>
- Subject: Re: PATCH/RFA : m68k_find_saved_regs
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Fri, 24 Mar 2000 14:09:33 +1100
- CC: "gdb-patches at sourceware dot cygnus dot com" <gdb-patches at sourceware dot cygnus dot com>
- Organization: Cygnus Solutions
- References: <200003231346.OAA31373@mail.macqel.be>
Philippe De Muyter wrote:
>
> The following patch fixes on m68k-motorola-sysv the retrieval of saved
> registers in the stack in case of a signal. Except for some m68k-motorola-sysv
> specific changes, it adds recognition of two more register-saving instructions
> to m68k-find_saved_regs, and allows them to appear in any order, not in a fixed
> sequence.
>
> OK to commit ?
Ok.
> Index: gdb/ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/gdb/ChangeLog,v
> retrieving revision 1.167
> diff -u -p -b -r1.167 ChangeLog
> --- ChangeLog 2000/03/23 04:27:26 1.167
> +++ ChangeLog 2000/03/23 12:44:18
> @@ -1,3 +1,22 @@
> +Thu Mar 23 13:18:26 2000 Philippe De Muyter <phdm@macqel.be>
> +
> + * m68k-tdep.c (P_LINKL_FP, P_LINKW_FP): Macros renamed from P_LINK_L
> + and P_LINK_W.
> + (P_PEA_FP, P_MOVL_SP_FP): New macros.
> + (P_MOVL, P_LEAL, P_MOVML): Macros renamed from P_MOV_L, P_LEA_L and
> + P_MOVM_L.
> + (altos_skip_prologue, isi_skip_prologue): Use P_* macros, not octal
> + constants.
> + (delta68_in_sigtramp): New function.
> + (delta68_frame_args_address, delta68_frame_saved_pc): Ditto.
> + (m68k_skip_prologue): Use P_* macros, not hex constants.
> + (m68k_find_saved_regs): Do not expect a fixed sequence of register save
> + instructions, but accept them in any order; use P_* macros, not octal
> + or hex constants; recognize also `fmovemx to (fp + displacement)' and
> + `moveml to (fp + displacement)'.
> + * m68/tm-delta68.h (IN_SIGTRAMP): New macro.
> + (FRAME_SAVED_PC, FRAME_ARGS_ADDRESS): Ditto.
> +
You're is the third person today :-) Could people please separate out
the ChangeLog entry. Having it lurking in a patch is dangerous :-).
> +CORE_ADDR
> +delta68_frame_saved_pc (frame_info)
> + struct frame_info * frame_info;
You're encouraged to use ISO-C style function definitions when adding
new code.
> +extern int delta68_in_sigtramp PARAMS ((CORE_ADDR pc, char * name));
> +#define IN_SIGTRAMP(pc,name) delta68_in_sigtramp (pc, name)
same here.
enjoy,
Andrew