This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [PATCH] Replace ../include/wait.h with gdb_wait.h.
- To: Mark Kettenis <kettenis at wins dot uva dot nl>
- Subject: Re: [PATCH] Replace ../include/wait.h with gdb_wait.h.
- From: Michael Snyder <msnyder at cygnus dot com>
- Date: Fri, 17 Mar 2000 11:47:12 -0800
- CC: ac131313 at cygnus dot com, gdb-patches at sourceware dot cygnus dot com
- Organization: Cygnus Solutions
- References: <38A12872.13D194C4@cygnus.com> <200002091429.e19ETk916570@delius.kettenis.local>
Mark Kettenis wrote:
> [snip]
> There is a problem with `linux-thread.c', where `gdb_wait.h' is included
> before config.h. This means that HAVE_SYS_WAIT_H and HAVE_WAIT_H are
> still undefined and the system headers are never used.
>
> Since `linux-thread.c' uses __W_STOPCODE, and `gdb_wait.h' doesn't
> provide a fallback macro I get a linker failure. Moving up the
> include for `defs.h' solves this problem.
As noted earlier, the above part of this patch has already
been checked in...
> The rest of GDB seems to be using WSETSTOP, so it seems appropriate to
> use that macro instead of __W_STOPCODE in `linux-thread.c'. I changed
> the definition of WSETSTOP and WSETEXIT in `gdb_wait.h' to use
> W_STOPCODE and W_EXITCODE if they are available. All BSD-derived
> systems and systems that try to be source-compatible with BSD (like
> Linux and the Hurd) should have those macros. The change is merely
> cosmetic but there might be systems out there that really use a
> different way to store this information.
And I've now checked in this part as well.
Michael Snyder