This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFA: set unwindonsignal (as promissed)


Elena Zannoni wrote:
> 
> Fernando Nasser writes:
>  > This patch makes everybody happy.  Just set the flag as you like.
>  >
>  > The default behavior is what gdb used to do before: stay in the frame
>  > where the signal occurred.
>  >
>  >
>  > 2000-02-18  Fernando Nasser  <fnasser@cygnus.com>
>  >
>  >         * top.c (init_main): Add command set unwindonsignal.
>  >         * infcmd.c (run_stack_dummy): Do not pop frame on random signal.
>  >         * valops.c (hand_function_call): Test for unwind_on_signal and
>  >         act accordingly.
>  >
> 
> Question: Does this command really belong to top.c? Should it be in
> valops.c instead, so you avoid the 'extern' in there? I would prefer
> so.

Sure.  Please consider the same patch with the following:

2000-02-18  Fernando Nasser  <fnasser@cygnus.com>

        * infcmd.c (run_stack_dummy): Do not pop frame on random signal.
        * valops.c (_initialize_valops): Add command set unwindonsignal.
	(hand_function_call): Test for unwind_on_signal and act accordingly.


> (see previous partially aborted idea with 'abandon'. BTW should we
> delete that?)
> 
I do think so, as it is not used anywhere.  I don't know who created and
who disabled it but it is history now -- gdb will always abandon the
expression evaluation and it would take a significant change to be able
to do it.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
Toronto, Ontario   M4P 2C9              Fax:  416-482-6299

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]