This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFC: Patch to arm-tdep.c -- Register flavors


> > And finally, the ps register name is wrong, especially in the A{T}PCS area
> > but also more generally; the name is "cpsr" in all ARM documentation (the
> > "ps" name comes from when the processor flags weren't really a separate
> > register -- they were in the unused parts of r15 -- so there was no name).
> 
> Richard is correct here, in arm-linux-nat.c, I initialize the PS register with
> the contents of CPSR if arm_apcs_32 is set, or with the contents of the PC if
> not.  Perhaps we should set the register name based on this information as well.


This is one of the few cases where I would just delete the old name.  Old 
processors never had a specific flags register, so the 'ps' name was 
'invented' by the original porter of gdb.  Since then the cpsr name has 
come into use and I doubt that even users debugging in 26-bit mode would 
object violently to this name changing (maybe we can support "ps" as an 
alias when parsing user input, but I see no point in ever printing 
anything other than "cpsr".

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]