Re: RFA: [complaints.c] Use warning_hook

[Fernando Nasser <fnasser at cygnus dot com>]

Andrew Cagney wrote:
> 
> Fernando Nasser wrote:
> >
> > The following patch prevents complaints to confuse the GUI (or any other
> > stuff which is looking at the GDB output).
> >
> > Complaints are sent to the warning_hook if one is defined.
> >
> > OK to commit?
> >
> > ChangeLog:
> >
> >         * complaints.c (complain): Call warning_hook if defined, instead of
> >         writting to gdb_stderr.
> >         (clear_complaints): Do not write anything to gdb_stderr if warning_hook
> >         is defined.
> 
> Ok.
> 
> Regarding the hooks.  We (as in everyone) needs to think about the
> future of gdb-events.[hc] (aka gdb-hooks.[hc] - in hindsight, gdb-events
> was a dumb name :-).
> 

Thanks.  I will check it in.

The "events" name was given by GUI people (I was not involved) because
for the GDB GUIs this hooks generate "events" that must be handled by the
graphical component.

The problem is: who will look for the *_hook functions in a -events file
(as opposed to a -hooks file)?  
Thanks God there is grep and SourceNavigator :-)

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9