This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA]: memory region attributes


> From: jtc@redback.com (J.T. Conklin)
> Date: 05 Dec 2000 17:20:38 -0800
> 
> gdb/doc Changelog Entry:
> 
> 2000-12-05  J.T. Conklin  <jtc@redback.com>
> 
> 	* gdbint.texinfo (Memory region attributes): New manual section.
[snip]
> Index: doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
> retrieving revision 1.30
> diff -c -r1.30 gdb.texinfo
> *** gdb.texinfo	2000/11/19 06:31:39	1.30
> --- gdb.texinfo	2000/12/06 01:06:41

The ChangeLog entry is for gdbint.texinfo (incorrect), but the diffs
are for gdb.texinfo (correct).

> + When a memory region is defined, it is given a number to identify it; 
> + to enable, disable, or remove a memory region; you specify that number.
                                                 ^
This should be a comma, I think.

> + require specific sized accesses.  If no access size attribute is
> + specified, @value{GDBN} may use any size accesses.
                            ^^^^^^^^^^^^^^^^^^^^^^^^^
I think "...may use accesses of any size" is better.

> + @subsubsection Data Cache
> + The data cache attributes set whether @value{GDBN} may can cache target
> + memory.

Either "may" or "can" above is redundant.

(Sorry if this text was in the previous draft and I didn't catch those
problems.)

Apart from those minor glitches, the doco changes are approved.

Thanks!

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]