This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] show_commands (top.c) bug fix
- To: David Taylor <taylor at cygnus dot com>
- Subject: Re: [RFA] show_commands (top.c) bug fix
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Wed, 15 Nov 2000 16:01:30 -0500
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Red Hat , Inc. - Toronto
- References: <200011152042.PAA27047@texas.cygnus.com>
It is CLI, so I guess I can approve it. Elena's interest on top.c is
related to the event loop.
Thanks for the fix.
Fernando
David Taylor wrote:
>
> [Here's another one I missed the first time through.]
>
> In show_commands (top.c), we find the line:
>
> num = (parse_and_eval_address (args) - history_base) - Hist_print / 2;
>
> Since num is just an integer, I'd like to change that to instead read:
>
> num = (parse_and_eval_long (args) - history_base) - Hist_print / 2;
>
> The ChangeLog entry would be:
>
> * top.c (show_commands): Replace call to parse_and_eval_address
> with a call to parse_and_eval_long as we are evaluating an
> integer, not an address.
>
> [Or, possibly just:
>
> * top.c (show_commands): Ditto.
>
> if I commit it the same time as the trace_find_tracepoint_command fix.]
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9