This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for gdb5.0; enable hardware watchpoints on UnixWare


John Hughes wrote:
> 
> This is a bit ugly: i386v4-nat.c has to have access to some things only
> known by procfs.c.
> 
> Is there a prettier/recommended way of doing this?

Without having looked at the patch yet, I'll comment
that modularity is of course a concern.  We just last year
did a major clean-up of procfs.c to untangle all of the
special-case spaghetti.

I'll have a look at this when I can find a moment.  ;-(

> Anyway here's the patch:
> 
> 2000-10-30  John Hughes  <john@CalvaEDI.COM>
> 
>         * i386v4-nat.c (i386_insert_watchpoint, i386_remove_watchpoint,
>         i386_check_watch_resources, i386_stopped_by_watchpoint,
>         i386_insert_aligned_watchpoint, i386_insert_unaliged_watchpoint):
>         use i386 debug registers to implement hardware watchpoints on
>         UnixWare systems.
> 
>         * procfs.c (proc_family) allow access to family specific
>         information (contains debug registers on UnixWare systems).
> 
>         * procfs.c (proc_command) allow other modules to issue commands
>         to the procfs ctl file.
> 
>         * config/i386/tm-i386v42mp.c (TARGET_HAS_HARDWARE_WATCHPOINTS,
>         TARGET_CAN_USE_HARDWARE_WATCHPOINT, HAVE_CONTINUABLE_WATCHPOINT,
>         HAVE_STEPPABLE_WATCHPOINT, STOPPED_BY_WATCHPOINT,
>         target_insert_watchpoint, target_remove_watchpoint): define.
> 
> --
> John Hughes <john@Calva.COM>,
>         CalvaEDI SA.                            Tel: +33-1-4313-3131
>         66 rue du Moulin de la Pointe,          Fax: +33-1-4313-3139
>         75013 PARIS.
> 
>     ---------------------------------------------------------------
> 
>                             Name: unixware-watch-patch.txt
>               Part 1.2      Type: Plain Text (text/plain)
>                         Encoding: quoted-printable

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]