This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: bug in tracepoint protocol implementation


Josef Ezra wrote:
> 
> hi
> 
> file: tracepoint.c
> function: stringify_collection_list
> 
> old:
>    count += strlen (end);
>    end += count ;
> 
> new:
>     count += strlen (end);
>     end = temp_buf + count ;
> 
> reasoning:
> When saving more then one memrange parameter, the old code
> leaves 'gaps' in the temp_buf string.

Josef, 

Your change is correct (thank you).  However, would you 
please re-submit it after consulting the file "CONTRIBUTING" 
in your gdb source directory?  Or see:
http://sources.redhat.com/gdb/#contribute

Briefly, to streamline the process of accepting GDB 
contributions, we request the following format:

  * brief description of the problem being addressed
  * ChangeLog entry
  * Diff of the changes, such as will be acceptable
    as input to "patch" (eg. "cvs diff -c3p tracepoint.c")

Hate to put you thru the exercise of resubmitting such a
simple patch, but it will be good experience if you intend
to make further GDB contributions (as I hope you will).

				Thanks,
				Michael Snyder

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]