This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: nrun.c patch
- To: cagney at redhat dot com, Stephane dot Carrez at worldnet dot fr
- Subject: Re: nrun.c patch
- From: Doug Evans <dje at transmeta dot com>
- Date: Sat, 9 Sep 2000 21:31:12 -0700
- cc: gdb-patches at sourceware dot cygnus dot com
[resend 'cus I screwed up the cc list]
I _really_ don't like this patch and would like it reverted.
Thu Jul 27 20:37:47 2000 Andrew Cagney <cagney@b1.cygnus.com>
From 2000-06-25 Stephane Carrez <Stephane.Carrez@worldnet.fr>:
* nrun.c (main): Print the simulator statistics only in
verbose mode.
I use to be able to say
"m32r-run -p foo" and get some useful output.
Now I have to say
"m32r-run -p -v foo"
The patch makes the user have to say
-p: "I'd like various profiling statistics collected please",
-v: "Oh, and by the way, I'd also like you to print them out.
Yes, I know there's no real point to collecting statistics
if I can't see them, but well, I'd really like to see them please."
Having to specify the -v with the -p is wrong.
One could have -p imply -v but I don't like that either.
The way things were -p gave the basic profiling data
and -p -v gave verbose profiling data.
I read in the patch submission from Stephane that the purpose
of the patch was to make nrun.c behave like run.c.
run.c is broken in so many ways, let's not use it as
a guide for how to do things.