Re: core dump support for cygwin

[Egor Duda <deo at logos-m dot ru>]

Hi!

Friday, 25 August, 2000 Chris Faylor cgf@cygnus.com wrote:

CF> I have a couple of very minor nits.

CF> It looks like you should be defining O_BINARY similarly to the way that it's
CF> done in exec.c.  Otherwise systems which don't support this open flag will have
CF> problems.

CF> (I wonder if this should actually be defined in defs.h or something since it is used
CF> all over the place in gdb)

CF> Your changes to win32-nat.c use both K&R function definitions and ANSI prototypes.
CF> Please just use the modern usages for all of your function definitions.

CF> I'd prefer if you renamed cygwin_solib_add to child_solib_add to make this consistent
CF> with the rest of the function names in the file.

done.

Egor.            mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19

cygwin-core-dump.gdb.ChangeLog

cygwin-core-dump.gdb.diff