This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] language support: case sensitivity


??? Please elaborate.  At the very least in the case of C++, it's case
sensitive, so there's no change with regard to the current behavior if
the patch is applied.  Besides, name is a char * parameter in
lookup_symtab.

- Jimmy

On 9 Aug 2000, Daniel Berlin wrote:

>Jim Blandy <jimb@zwingli.cygnus.com> writes:
>
>Damnit, i'm five seconds away from submitting a patch to remove the
>linear searches on C++ symbols completely, and I do it by always
>demangling the name we search for, so i also make a copy of the name
>in case demangling fails, and you go approve a patch that changes the
>name.
>
>--Dan
>> This is approved, with the following changes:
>> 
>> Scheme is not case-sensitive.  R5RS, section 2: "Upper and lower case
>> forms of a letter are never distinguished except within character and
>> string constants.  For example, Foo is the same identifier as FOO, and
>> #x1AB is the same number as #X1ab."
>> 
>> In lookup_symbol, please just go ahead and change the value of `name';
>> don't change every use of `name' to `copy'.  `copy' is a poor variable
>> name.  If it is necessary to keep the original, unmodified name
>> around, keep it in a variable named `original_name'.  (But I don't see
>> any remaining uses of `name', so I don't think this is necessary.)
>> 
>> Please update the comment above the call to check_field.
>> 
>> Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]