This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Testsuite patches...
- To: GDB Discussion <gdb at sourceware dot cygnus dot com>
- Subject: Re: RFA: Testsuite patches...
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Wed, 02 Aug 2000 21:55:34 +1000
- CC: Fernando Nasser <fnasser at cygnus dot com>, Scott Bambrough <scottb at netwinder dot org>, Michael Snyder <msnyder at cygnus dot com>, GDB Patches Mail List <gdb-patches at sourceware dot cygnus dot com>
- References: <39803B5C.9C31BB15@netwinder.org> <3980469B.E0BD7ED2@cygnus.com> <3980D60D.6EAB40A8@cygnus.com>
[suggest following up to gdb@sourceware - not patch specific]
Andrew Cagney wrote:
>
> Um, careful here.
Double Um, I should be more careful, sorry :-(
> I don't think the question to ask is ``who will fix the failures''.
> Rather, I think people should be asking ``does the test check correct
> functionality''?
>
> If the test is correct and applicable to more than just HP then I think
> it should be enabled. If it adds to the number of failures for certain
> targets then ``oops'' :-) I'd assume the relevant maintainers would
> simply append this to their list of known problems.
>
> Perhaphs post something like a transcript (assuming they are not to
> large) of each test so people can see them in action.
>
> As a generalization, GDB desperatly needs more tests.
Its been pointed out I've got the current policy wrong. There was a
debate (internal to Cygnus though :-() but the policy didn't get changed
- in general a testsuite shouldn't go in unless it is accompanied by a
fix.
From the above you can tell that I think this is too stringent. I think
GDB should be accepting tests (provided that they are rigiously
examined) even when they add failures - just as long as the failures
examine real bugs. I think this also better reflects what really goes
on.
BTW, as twist too all this, HP and Cygnus were quietly contributing
tests (call-*-st.exp in particular) which, at least initially, only
passed on HP platforms.
thoughs?
enjoy,
Andrew