Re: RFC: changes to configure.in and configure

[Andrew Cagney <ac131313 at cygnus dot com>]

Scott Bambrough wrote:
> 
> Hello,
> 
> I noticed last week that gdbserver was not building on my ARM Linux box
> automatically even though it was specified in configdirs in configure.tgt.  It
> seems none of the modifications to configdirs in configure.tgt were being
> applied.  I'd like to apply the following patch to configure.in which fixes this
> problem if no on has any objections.  The changes to configure are the diffs
> after configure was regenerated using autoconf 2.13 as Andrew suggested.
> 
> Scott

I'm not sure how this patch:

Index: gdb/configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.40
diff -u -p -r1.40 configure.in
--- configure.in        2000/07/27 04:01:24     1.40
+++ configure.in        2000/07/31 15:59:59
@@ -1014,12 +1014,19 @@ if test "${target}" = "${host}"; then
 nativefile=`sed -n '
 s/NAT_FILE[    ]*=[    ]*\([^  ]*\)/\1/p
 ' ${host_makefile_frag}`
-# else
+else
 # GDBserver is only useful in a "native" enviroment
-# configdirs=`echo $configdirs | sed 's/gdbserver//'`
+configdirs=`echo $configdirs | sed 's/gdbserver//'`
 fi
 changequote([,])
 
+SUBDIRS="doc testsuite nlm $configdirs"
+if test "${enable_multi_ice}" = "yes"; then
+  SUBDIRS="${SUBDIRS} multi-ice"
+fi
+
+AC_SUBST(SUBDIRS)
+
 # New targets should just set gdb_multi_arch=yes in configure.tgt.
 # Old targets being converted can either do that or set GDB_MULTI_ARCH
 # in the target specific makefile frag.  Eventually gdb_multi_arch=yes
@@ -1045,14 +1052,6 @@ case "${GDB_MULTI_ARCH}" in
        fi ;;
     *)  AC_MSG_ERROR("GDB: Unknown GDB_MULTI_ARCH value
${GDB_MULTI_ARCH}");;
 esac
-
-
-SUBDIRS="doc testsuite nlm"
-if test "${enable_multi_ice}" = "yes"; then
-  SUBDIRS="${SUBDIRS} multi-ice"
-fi
-
-AC_SUBST(SUBDIRS)
 
 # If hostfile (XM_FILE) and/or targetfile (TM_FILE) and/or nativefile
 # (NAT_FILE) is not set in config/*/*.m[ht] files, we don't make the


changes things. Hmmmmm, ah this bit:

-SUBDIRS="doc testsuite nlm"
+SUBDIRS="doc testsuite nlm $configdirs"

has something to do with it - be careful to not re-order code
unnecessarily - it can hide real changes.

From memory (and grubbing around old changelogs) things are currently
set up to:

	o	not build gdbserver
		(suprize!)

	o	always configure GDBSERVER
		(when selected)

Your change would completly reverse this.  I don't know that that was
the intention.

	Andrew