This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH]: gas/sim/opcodes Warnings


Hi -

> > [... the patched code] looks weirdly inconsistent.  Do none
> > of the other sim_queue_* write_functions use the arguments?
> 
> Yeah, I know. The problem is that cgen considers DI to be an
> integral type and assumes that the signed and unsigned variants
> are compatible. However on some platforms, DI is implemented as a
> struct 

Yeah, eww.


> and so the signed and unsigned variants are not
> compatible. This is what leads to the warnings.

I'd be more comfortable with spelling out the whole spectrum of
types in the sim_queue_*_write functions (unsigned AND signed).
They can internally collapse the cases by casting away signedness
or whatever means is appropriate.


> This change does not declare write_function to be a function with
> no arguments. In C, this means a function with unspecified
> arguments.

Yeah, I showed my C++ shadow.  Still, specifying arguments is goodness.


- FChE

PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]