This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: patch for sparc-tdep.c for NetBSD/sparc.
J.T. Conklin wrote:
>
> >>>>> "Michael" == Michael Snyder <msnyder@cygnus.com> writes:
> >> It's better, but I think the suggestions were to add the following
> >> macros.
> >>
> >> #define GDB_GREGSET_T struct reg
> >> #define GDB_FPREGSET_T struct fpreg
> >>
> >> as that is a more direct way of defining the types.
>
> Michael> I really like typedefs better. They are debuggable,
> Michael> #defines are not.
>
> I don't see that this is much different than the GDB_{G,FP}REGSET_T
> macro definitions in gregset.h.
I'm not saying "mine's better", I'm just saying when I have
the choice to use a macro or a typedef, I prefer a typedef.
You can say "printtype gdb_gregset_t" if it's a typedef,
but not if it's a macro.