This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: RFA: AIX 64-bit mega-patch
On Jun 13, 9:13pm, Nick Duffek wrote:
> >Rather than messing with call dummies, I would really prefer that we
> >use generic dummy frames (see "GENERIC DUMMY FRAMES" in blockframe.c
> >for more info.)
>
> We do unless the architecture is pre-PowerPC, in which case the old
> non-generic code gets activated. This is the relevant part of the patch:
>
> + if (rs6000)
> + {
> + set_gdbarch_use_generic_dummy_frames (gdbarch, 0);
> [...]
> }
> + else
> + {
> + set_gdbarch_use_generic_dummy_frames (gdbarch, 1);
>
> The rs6000 variable is 1 for pre-PowerPC architectures and 0 otherwise.
I would like us to use generic dummy frames for both cases. This
is one of the things I wanted to do last February, but I didn't have
time to test it.
> So, is it still okay to apply this patch? As I mentioned in an earlier
> message, I'd really like to check this in as-is and deal with
> non-showstopper issues via follow-on patches rather than modifying this
> patch and reposting the whole 125k.
I see your point. After you've applied the BFD changes (and any other
pending changes -- I've lost track), feel free to apply your mega-patch.
Then clean up from there. (Again, let me know when you've applied it,
so I can take a look at fixing GNU/Linux/PPC.)
Thanks,
Kevin