This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: RFA: Fix to value.c (value_primitive_field)
- To: Fernando Nasser <fnasser at cygnus dot com>
- Subject: Re: RFA: Fix to value.c (value_primitive_field)
- From: David Taylor <taylor at cygnus dot com>
- Date: Mon, 12 Jun 2000 10:05:43 -0400
- cc: Andrew Cagney <ac131313 at cygnus dot com>, gdb-patches at sourceware dot cygnus dot com
Date: Fri, 09 Jun 2000 00:46:24 +0000
From: Fernando Nasser <fnasser@cygnus.com>
Fernando Nasser wrote:
>
> Andrew Cagney wrote:
> >
> > Fernando Nasser wrote:
> > >
> > > The ChangeLog entry says all.
> >
> > Its probably all ok. I'm just wondering what was going on to cause the
> > needed change?
> >
>
> This is necessary so we can properly access bitfields that live in registers.
> We want to type status registers so we can individually see/change the bits.
>
I guess this was a yes, so I am checking it in.
I don't remember the original email, but I approve of the change.
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@cygnus.com
Index: values.c
===================================================================
RCS file: /cvs/src/src/gdb/values.c,v
retrieving revision 1.6
diff -c -p -r1.6 values.c
*** values.c 2000/05/28 01:12:33 1.6
--- values.c 2000/05/30 14:07:26
*************** value_primitive_field (arg1, offset, fie
*** 841,846 ****
--- 841,847 ----
if (VALUE_LVAL (arg1) == lval_internalvar)
VALUE_LVAL (v) = lval_internalvar_component;
VALUE_ADDRESS (v) = VALUE_ADDRESS (arg1);
+ VALUE_REGNO (v) = VALUE_REGNO (arg1);
/* VALUE_OFFSET (v) = VALUE_OFFSET (arg1) + offset
+ TYPE_FIELD_BITPOS (arg_type, fieldno) / 8; */
return v;