This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [PATCH]: Make solib.c more multi-archable
Date: Thu, 04 May 2000 15:25:31 -0700
From: Michael Snyder <msnyder@cygnus.com>
OK, how about this (same ChangeLog entry):
Looks good. Except that according to the GNU coding standards
comments should consist of full sentences starting with a capital and
eding with a dot, and that lines have to be split before an operator.
So
if (arch_size == 32 ||
arch_size == -1) /* default to 32-bit in case of failure (non-elf) */
should be formatted as
if (arch_size == 32
|| arch_size == -1) /* Default to 32-bit in case of failure (non-elf). */
Of course that one could probably be better written as
/* Default to 32-bit in case of failure (non-elf). */
if (arch_suize == 32 || arch_size == -1)
:-)
Mark
PS. Yes, I know, I'm just an annoying nit-picker.