This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: retry: Patch to dwarf2read.c
- To: Jason Merrill <jason at cygnus dot com>
- Subject: Re: retry: Patch to dwarf2read.c
- From: Jim Blandy <jimb at cygnus dot com>
- Date: 11 Oct 1999 11:02:29 -0500
- Cc: gdb-patches at sourceware dot cygnus dot com
- References: <u9puz3vs3q.fsf@yorick.cygnus.com>
> Other backends don't set main_func_*, so there seems to be no reason why
> the dwarf ones should, especially since the test they use may be wrong.
>
> It seems silly to go to the trouble of extracting the simple name for
> class members when it's already there in the debugging information.
>
> I'd also like to remove dwarf2read's other dependencies on
> DW_AT_MIPS_linkage_name, since it's not part of the spec and takes up a lot
> of space. As it is, we rely on that attribute to find class members,
> through the symbol table. But that shouldn't be necessary; the definitions
> of the members tell you what they're defining, so you should be able to
> update the field/fn_field at that time.
>
> 1999-09-15 Jason Merrill <jason@yorick.cygnus.com>
>
> * dwarfread.c (read_func_scope): Don't try to set main_func_*.
> * dwarf2read.c (read_func_scope): Likewise.
> (dwarf2_add_field, dwarf2_add_member_fn): Get member function name
> directly, not from mangled name.
This looks great. Please commit it.
- Please also delete skip_member_fn_name, since you've deleted its only use.
- You might want to note in your ChangeLog entry that inside_main_func
in blockframe.c takes care of setting main_func_{low,high}pc.